Fix typescript build by adding static types dependency list #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default typescript tries to build any given types available in its build scope but that brings some issue when the consumer project import types dependencies because tsc would then try to compile them as well whereas they should remains out of the build scope of the library. In order to solve this I've statically listed all types dependencies of this project in the types attribute of ts config file.
JBWatenbergScality
force-pushed
the
browser-0.10.2-fix-typescript
branch
from
7494073 to
e74042e
Compare
ChengYanJin
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default typescript tries to build any given types available in its build scope but that brings some issue when the consumer project import types dependencies because tsc would then try to compile them as well whereas they should remains out of the build scope of the library.
In order to solve this I've statically listed all types dependencies of this project in the types attribute of ts config file.